Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s root ESLint configuration to enforce more consistent TypeScript import/export patterns and import sorting, as a foundation for a larger import-cleanup effort across packages/apps.
Changes:
- Enable
@typescript-eslint/consistent-type-importsand@typescript-eslint/consistent-type-exportsas errors. - Enable ESLint core
sort-importsas an error.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
## Description This PR fixes eslint errors in package after enabling new `import` rules ## Test plan - `yarn ts-check` - `yarn lint-js` I've also run Sonnet to make sure that only `imports` were affected: <img width="1018" height="289" alt="image" src="https://github.com/user-attachments/assets/bdc7a858-ae67-4fc2-9152-cf12dc8cac38" />
## Description This PR fixes eslint errors in package after enabling new import rules >[!NOTE] >`images.d.ts` was added because otherwise it is not possible to import `*.png` as `import` statement. ## Test plan - `yarn ts-check` - `yarn lint-js` <img width="1053" height="441" alt="image" src="https://github.com/user-attachments/assets/e4490888-2484-4380-8bd3-92ee57a6ed97" />
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 299 out of 301 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add new eslint rules, that:
typewhen importing only typesAs there would be too many changes, I've decided to split this into two PRs. This one will be base, similarly as in monorepo migration.
Test plan
yarn lint-jsyarn ts-check