Skip to content

[Android] Correct Rotation handler #4079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-bert merged 1 commit into from
Apr 13, 2026
+10 −7
Merged

[Android] Correct Rotation handler #4079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions ...handler/android/src/main/java/com/swmansion/gesturehandler/core/RotationGestureHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ class RotationGestureHandler : GestureHandler() {
override fun onRotationBegin(detector: RotationGestureDetector) = true

override fun onRotationEnd(detector: RotationGestureDetector) {
end()
if (state == STATE_ACTIVE) {
end()
} else {
fail()
}
}
}

Expand Down Expand Up @@ -64,12 +68,11 @@ class RotationGestureHandler : GestureHandler() {
anchorX = point.x
anchorY = point.y
}
if (sourceEvent.actionMasked == MotionEvent.ACTION_UP) {
if (state == STATE_ACTIVE) {
end()
} else {
fail()
}

// ACTION_UP is already handled in rotationGestureDetector.onTouchEvent (and effectively in onRotationEnd)
// if more than one pointer was used
if (sourceEvent.actionMasked == MotionEvent.ACTION_UP && state == STATE_BEGAN) {
fail()
}
}

Expand Down
Loading