Conversation
m-bert
left a comment
There was a problem hiding this comment.
Good job! I really like new look of our app ❤️
I've left some suggestions, let me know what do you think about them.
Also there's one problem - transformations example no longer works on web. Could you please check that?
|
Also, one more detail
I think that combo example still uses |
|
Most likely yes. Update: removed in 156c3bc |
Co-authored-by: Michał Bert <63123542+m-bert@users.noreply.github.com>
Co-authored-by: Michał Bert <63123542+m-bert@users.noreply.github.com>
… @jpiasecki/update-examples
It seems like passing the matrix as transform directly didn't work on web. Now it applies styles, but they are not right. It looks like on web |
You can open an issue. I will look into it later 😅 |
… @jpiasecki/update-examples
|
I've moved the complex transform logic to the separate PR so this stops being blocked by wrong anchor/focal points on web - #3124 |
m-bert
left a comment
There was a problem hiding this comment.
I've moved the complex transform logic to the separate PR so this stops being blocked by wrong anchor/focal points on web - #3124
So I think we can remove matrices from description:
updates Transformations to use matrices and update the look
## Description Fix broken links in the `quickstart` docs page. - replace the `SharedValue` description link - replace the `ballTest` code link broken in #2919 ## Test plan - open the old links - open the new links - see how the old links are broken
Description
New Apisection to the topVelocity TestwithSimple Reanimated exampleOverlap ParentandOverlapSiblingsTransformationsCamerasince the camera was missing therePan Responderto not usesetNativePropswhich was removed on RN webTest plan
Check the updated examples