fix: restore react-native-worklets as an optional peer dep#1037
Open
shubh73 wants to merge 2 commits intosoftware-mansion:mainfrom
Open
fix: restore react-native-worklets as an optional peer dep#1037shubh73 wants to merge 2 commits intosoftware-mansion:mainfrom
shubh73 wants to merge 2 commits intosoftware-mansion:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None at runtime.
This does slightly change install-time signaling: package managers may now show an advisory optional-peer message when
react-native-workletsis not installed directly. That matchesreact-native-audio-apiinv0.10.1.Introduced changes
react-native-workletsas an optional peer dependency with version range>= 0.6.0scripts/validate-worklets-version.jswhere the warning referencedreact-native-audio-workletsinstead ofreact-native-workletsWhy
The iOS podspec still requires
RNWorkletswhenever node can resolvereact-native-worklets.But CocoaPods autolinking only sees packages declared directly in the consumer app. So when
react-native-workletsis only present transitively (for example viapressto), consumers can hit:Unable to find a specification for RNWorkletsduring
pod install, with no package-level hint thatreact-native-workletsis expected as a direct dependency.Checklist