Use closure in PurgeOn::if#116
Draft
Brajk19 wants to merge 30 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #116 +/- ##
============================================
- Coverage 97.48% 97.42% -0.07%
- Complexity 518 537 +19
============================================
Files 69 69
Lines 1431 1473 +42
============================================
+ Hits 1395 1435 +40
- Misses 36 38 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 tasks
Brajk19
commented
Jun 11, 2026
Comment on lines
+77
to
+78
| // TODO support closures | ||
| throw new \RuntimeException('Cannot create inverse subscription with closures'); |
Member
Author
There was a problem hiding this comment.
will be implemented in following PR because this one is already big
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for using closure in PurgeOn::if for php 8.5+
opis/closure is used for serializing/deserializing closures. its an optional dependency.