Set multiple cookies in multiple set-cookie headers#101
Open
sulami wants to merge 1 commit intosocketry:mainfrom
Open
Set multiple cookies in multiple set-cookie headers#101sulami wants to merge 1 commit intosocketry:mainfrom
set-cookie headers#101sulami wants to merge 1 commit intosocketry:mainfrom
Conversation
This fixes a bug we've hit with Falcon & Rails, where multiple cookies set on a single response would return a single `set-cookie` header with the values from several cookies joined by `;`, which browsers do not accept, and is not compliant with the spec in RFC 6265. This required decoupling the `Cookie` and `SetCookie` implementations, so we can splat `Multiple` into `@fields`. This also introduces spaces after semicolons into the output of `cookie#to_s`, which is also required by the spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug we've hit with Falcon & Rails, where multiple cookies set on a single response would return a single
set-cookieheader with the values from several cookies joined by;, which browsers do not accept, and is not compliant with the spec in RFC 6265.This required decoupling the
CookieandSetCookieimplementations, so we can splatMultipleinto@fields.This also introduces spaces after semicolons into the output of
cookie#to_s, which is also required by the spec.Types of Changes
Contribution
set-cookieheader, and confirmed behaviour before and after this fix.