Feat/http subscription#2
Merged
PoulavBhowmick03 merged 5 commits intosmartprogrammer93:feat/http-subscriptionfrom Mar 4, 2026
Merged
Feat/http subscription#2PoulavBhowmick03 merged 5 commits intosmartprogrammer93:feat/http-subscriptionfrom
PoulavBhowmick03 merged 5 commits intosmartprogrammer93:feat/http-subscriptionfrom
Conversation
LeoPatOZ
reviewed
Mar 4, 2026
| impl<N: Network> From<PollerBuilder<(U256,), Vec<BlockHash>>> for SubscriptionBackend<N> { | ||
| fn from(value: PollerBuilder<(U256,), Vec<BlockHash>>) -> Self { | ||
| use futures_util::{StreamExt, stream}; | ||
| use tokio_stream::StreamExt; |
Author
There was a problem hiding this comment.
It's only used in this scope, and only when #[cfg(feature = "http-subscription")] is true (again, in this scope), so it's fine
smartprogrammer93
approved these changes
Mar 4, 2026
Owner
|
@0xNeshi looks good. Merge at will |
Author
You'll have to do it, I don't have permission to merge |
PoulavBhowmick03
approved these changes
Mar 4, 2026
Collaborator
PoulavBhowmick03
left a comment
PoulavBhowmick03
left a comment
There was a problem hiding this comment.
Added/Updated documentation around the changes and refactor in subscription.rs, removing futures_util dependency, using tokio_stream instead
PoulavBhowmick03
merged commit a6272cd
into
smartprogrammer93:feat/http-subscription
6 of 7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to merge OpenZeppelin#32