Refactoring SdlRouterService and SdlBroadcastReceiver#1352
Draft
Refactoring SdlRouterService and SdlBroadcastReceiver#1352
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1352 +/- ##
=============================================
- Coverage 47.67% 47.67% -0.01%
- Complexity 4432 4433 +1
=============================================
Files 489 491 +2
Lines 23848 23851 +3
Branches 2753 2753
=============================================
+ Hits 11369 11370 +1
- Misses 11778 11780 +2
Partials 701 701
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #349
This PR is [not ready] for review.
Risk
This PR makes [minor] API changes.
Testing Plan
Summary
This branch will deprecate SDLRouterService and SDLBroadcastReceiver and create BaseRouterService and BaseBroadcastReceiver which extend these deprecated classes. This is because there is a lot of confusion added by the creating a SDLRouterService class in the application which uses the same name as its parent class.
CLA