DON-Level Metrics: Emit classified workflow errors#23136
Open
DylanTinianov wants to merge 3 commits into
Open
Conversation
DylanTinianov
marked this pull request as ready for review
July 15, 2026 19:11
product-security-plaid-production
Bot
requested review from
kalverra and
vyzaldysanchez
July 15, 2026 19:11
DylanTinianov
added
build-test-image
| logCustMsg(ctx, cma, fmt.Sprintf("execution duration: %d (seconds)", executionDuration), l) | ||
| l.Infof("execution duration: %d (seconds)", executionDuration) | ||
| err = events.EmitExecutionFinishedEvent(ctx, cma.Labels(), status, executionID, nil, l) | ||
| // v1 engine does not classify user vs system failures. |
Contributor
There was a problem hiding this comment.
/nit i'd rather just drop this diff in favor of (eventually) deprecating the v1 engine
Contributor
|
✅ No conflicts with other open PRs targeting |
|
DylanTinianov
changed the title
patrickhuie19
approved these changes
Jul 16, 2026
DylanTinianov
enabled auto-merge
July 17, 2026 14:06
tarcisiozf
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
Supports