[DX-3769] Adds a fix-flaky-go-test agent skill#22010
[DX-3769] Adds a fix-flaky-go-test agent skill#22010
Conversation
|
👋 kalverra, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
kalverra
changed the title
|
✅ No conflicts with other open PRs targeting |
There was a problem hiding this comment.
Pull request overview
Risk Rating: LOW — documentation-only change, but it directly guides automated workflows so correctness matters.
Adds a Chainlink-specific fix-flaky-go-test agent skill with repo-specific reproduction and fixing guidance for intermittent Go test failures.
Changes:
- Introduces a new
.agents/skills/fix-flaky-go-test/SKILL.mddescribing setup, reproduction steps, common root causes, and fix patterns. - Aligns the guidance with Chainlink CI tooling (
tools/bin/*) and database setup (.dbenv,make testdb). - Documents optional CI parity knobs (e.g.,
GODEBUG=goindex=0) and race/stress testing workflows.
| Append --tags integration to every go test below if the file has //go:build integration. | ||
| deployment/ CCIP: use tools/bin/go_core_ccip_deployment_tests pattern (cd deployment, CL_RESERVE_PORTS=128). | ||
| Optional CI parity: GODEBUG=goindex=0 on go test (see ci-core.yml). | ||
| If the file uses //go:build dev or trace, add matching --tags when reproducing. |
There was a problem hiding this comment.
go test uses the -tags flag (e.g., -tags=integration), not --tags. As written, --tags integration will be rejected by go test and would break the reproduction instructions (and any agent automation relying on them).
| Append --tags integration to every go test below if the file has //go:build integration. | |
| deployment/ CCIP: use tools/bin/go_core_ccip_deployment_tests pattern (cd deployment, CL_RESERVE_PORTS=128). | |
| Optional CI parity: GODEBUG=goindex=0 on go test (see ci-core.yml). | |
| If the file uses //go:build dev or trace, add matching --tags when reproducing. | |
| Append -tags integration to every go test below if the file has //go:build integration. | |
| deployment/ CCIP: use tools/bin/go_core_ccip_deployment_tests pattern (cd deployment, CL_RESERVE_PORTS=128). | |
| Optional CI parity: GODEBUG=goindex=0 on go test (see ci-core.yml). | |
| If the file uses //go:build dev or trace, add matching -tags when reproducing. |
| <verify> | ||
| Write the exact repro go test line including -run and --tags integration when relevant. | ||
| Race: GORACE log_path, go test -race -shuffle on, confirm no race.* or document skip. |
There was a problem hiding this comment.
This section again references --tags integration, but go test expects -tags (e.g., -tags=integration). Please update the example wording so users copy/pasting the repro line don’t get an "unknown flag: --tags" error.
|
Based on the general
fix-flaky-go-testskill, but modified to fit /chainlink specifically.