Skip to content

DF-23489 TestStartSendOnlyNode: deflakify assertions #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vlfig wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

DF-23489 TestStartSendOnlyNode: deflakify assertions #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions multinode/send_only_node_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ func TestStartSendOnlyNode(t *testing.T) {
s := NewSendOnlyNode(lggr, makeMockNodeMetrics(t), url.URL{}, t.Name(), RandomID(), client)

defer func() { assert.NoError(t, s.Close()) }()
assert.Equal(t, nodeStateUndialed, s.State())
err := s.Start(tests.Context(t))
require.NoError(t, err)

assert.Equal(t, nodeStateUndialed, s.State())
tests.AssertEventually(t, func() bool { return s.State() == nodeStateUnusable })
tests.RequireLogMessage(t, observedLogs, "Dial failed: SendOnly Node is unusable")
})
Expand All @@ -64,10 +64,10 @@ func TestStartSendOnlyNode(t *testing.T) {
s := NewSendOnlyNode(lggr, makeMockNodeMetrics(t), url.URL{}, t.Name(), NewIDFromInt(0), client)

defer func() { assert.NoError(t, s.Close()) }()
assert.Equal(t, nodeStateUndialed, s.State())
err := s.Start(tests.Context(t))
require.NoError(t, err)

assert.Equal(t, nodeStateUndialed, s.State())
tests.AssertEventually(t, func() bool { return s.State() == nodeStateAlive })
tests.RequireLogMessage(t, observedLogs, "sendonly rpc ChainID verification skipped")
})
Expand All @@ -86,10 +86,10 @@ func TestStartSendOnlyNode(t *testing.T) {
s := NewSendOnlyNode(lggr, metrics, url.URL{}, t.Name(), chainID, client)

defer func() { assert.NoError(t, s.Close()) }()
assert.Equal(t, nodeStateUndialed, s.State())
err := s.Start(tests.Context(t))
require.NoError(t, err)

assert.Equal(t, nodeStateUndialed, s.State())
tests.AssertEventually(t, func() bool { return s.State() == nodeStateUnreachable })
tests.AssertLogCountEventually(t, observedLogs, fmt.Sprintf("Verify failed: %v", expectedError), failuresCount)
client.On("ChainID", mock.Anything).Return(chainID, nil)
Expand All @@ -112,10 +112,10 @@ func TestStartSendOnlyNode(t *testing.T) {
s := NewSendOnlyNode(lggr, metrics, url.URL{}, t.Name(), configuredChainID, client)

defer func() { assert.NoError(t, s.Close()) }()
assert.Equal(t, nodeStateUndialed, s.State())
err := s.Start(tests.Context(t))
require.NoError(t, err)

assert.Equal(t, nodeStateUndialed, s.State())
tests.AssertEventually(t, func() bool { return s.State() == nodeStateInvalidChainID })
tests.AssertLogCountEventually(t, observedLogs, "sendonly rpc ChainID doesn't match local chain ID", failuresCount)
tests.AssertEventually(t, func() bool {
Expand Down
Loading