beholder: apply 1s MetricReaderInterval default when config field is zero#2230
Draft
pkcll wants to merge 1 commit into
Draft
beholder: apply 1s MetricReaderInterval default when config field is zero#2230pkcll wants to merge 1 commit into
pkcll wants to merge 1 commit into
Conversation
…zero Partial beholder.Config literals left MetricReaderInterval at zero, which OTel interpreted as its own 60s default instead of Beholder's intended 1s. Centralize effective defaulting inside beholder and record the resolved interval in the config gauge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metricReaderInterval()so partialbeholder.Configliterals get Beholder's 1s default instead of OTel's 60s fallback whenMetricReaderIntervalis zeroPeriodicReaderand in thebeholder.config.infogauge attributechainlink/core/cmd/shell.go,pkg/loop/server.go)Test plan
go test ./pkg/beholder/...beholder.config.info{metric_reader_interval="1s"}on a node using partial config literals after deployMade with Cursor