Conversation
|
Looks like the new Golang version is introducing some new lint rules. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
- Coverage 64.73% 64.71% -0.02%
==========================================
Files 212 212
Lines 17809 17805 -4
==========================================
- Hits 11528 11523 -5
- Misses 5207 5209 +2
+ Partials 1074 1073 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
left a comment
There was a problem hiding this comment.
🤯 Thanks so much for making these updates @zimeg! I've seen other projects struggling with these new linter rules.
🧹 Overall, I think the rules are helping to create more consist code, but it was a lot to update in order to bump our Golang.
🙇🏻 Thanks for doing it!
| project, _ := clients.SDKConfig.Exists() | ||
| if !project { | ||
| clients.IO.PrintInfo(ctx, false, style.Sectionf(style.TextSection{ | ||
| clients.IO.PrintInfo(ctx, false, "%s", style.Sectionf(style.TextSection{ |
There was a problem hiding this comment.
note: I remember in a previous life we had this syntax and had to remove it due to the linter. Now it's back 😆
|
@mwbrooks Woo! And thanks for help in keeping us current with these changes 👾 ✨ I'm wondering if this is more strict enforcement of this formatting syntax to remove chances of generating an unexpected template placeholder Let's merge this to build with confidence in the latest 🌚 🚢 |
Automatic update to the latest release of Go