fix: format release notification output#2631
Conversation
|
|
Thanks for the contribution! Before we can merge this, we need @jibin7jose to sign the Salesforce Inc. Contributor License Agreement. |
|
This workflow-only change does not require a package version bump, so no changeset was added. |
|
I have completed the Salesforce CLA. This PR is ready for maintainer review when workflows are approved. Thanks! |
|
The Salesforce CLA page shows that I already signed the CLA on 2026-06-21, but the Could a maintainer please refresh/re-run the CLA check when possible? |
|
Hi maintainers, |
jibin7jose
force-pushed
the
fix-release-notification-output
branch
from
2cd273d to
e911acf
Compare
|
Thanks, the CLA check is passing now. Could a maintainer please approve the pending workflows when convenient? |
jibin7jose
force-pushed
the
fix-release-notification-output
branch
from
4af8dfb to
01c9d6c
Compare
|
Hi maintainers, Just following up on this PR. CLA is now signed successfully, and the branch is up to date with main. The workflows are still awaiting maintainer approval, so CI checks have not started yet. When convenient, could someone please approve the workflows and review the PR? Thanks for your time. |
zimeg
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2631 +/- ##
=======================================
Coverage 88.90% 88.90%
=======================================
Files 63 63
Lines 10256 10256
Branches 452 452
=======================================
Hits 9118 9118
Misses 1117 1117
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
@jibin7jose Thanks so much for investigating the line breaking cause of these concern. YAML is... interesting 🦠
I'm feeling solid about this fix and am now curious if we can better support changesets as part of the Slack GitHub Action but that might be exploration for another time 🐙
| run: | | ||
| echo "message=$(echo "$PUBLISHED_PACKAGES" | jq -r '[.[] | "\(.name)@\(.version)"] | join(", ")')" >> "$GITHUB_OUTPUT" | ||
| echo "action_url=$(echo "$PUBLISHED_PACKAGES" | jq -r '[.[] | "https://github.com/${{ github.repository }}/releases/tag/\(.name)@\(.version)"] | join("\n")')" >> "$GITHUB_OUTPUT" | ||
| echo "action_url=$(echo "$PUBLISHED_PACKAGES" | jq -r '[.[] | "https://github.com/${{ github.repository }}/releases/tag/\(.name)@\(.version)"] | join(", ")')" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
🔬 note: We'll trade extended lines for correctness without worries at this time!
$ PUBLISHED_PACKAGES='[{"name": "@xx/xx", "version": "1.2.0"}, {"name": "@xx/xy", "version": "0.8.9"}]' echo "action_url=$(echo "$PUBLISHED_PACKAGES" | jq -r '[.[] | "https://github.com/${{ github.repository }}/releases/tag/\(.name)@\(.version)"] | join(", ")')"
action_url=https://github.com/${{ github.repository }}/releases/tag/@xx/xx@1.2.0, https://github.com/${{ github.repository }}/releases/tag/@xx/xy@0.8.9
|
🌟 note: Let's follow up later with a release of #2628 in hopes these errors disappear! |
2 participants
Summary
Fixes #2610.
This updates the release workflow to write the
action_urloutput using GitHub Actions multi-line output syntax. The previousname=valueformat failed when multiple packages were published because the release URLs were joined with newlines.Requirements