feat(web-api): add highlight_type to files.completeUploadExternal and filesUploadV2#2594
Open
zimeg wants to merge 5 commits into
Open
feat(web-api): add highlight_type to files.completeUploadExternal and filesUploadV2#2594zimeg wants to merge 5 commits into
zimeg wants to merge 5 commits into
Conversation
… filesUploadV2 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
🦋 Changeset detectedLatest commit: 37f8dfa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2594 +/- ##
==========================================
- Coverage 87.52% 87.51% -0.01%
==========================================
Files 62 62
Lines 10228 10230 +2
Branches 418 419 +1
==========================================
+ Hits 8952 8953 +1
- Misses 1254 1255 +1
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
WilliamBergamin
approved these changes
May 13, 2026
Contributor
WilliamBergamin
left a comment
There was a problem hiding this comment.
Praise 🙏 thanks for working on this 💯
NOTE: I think this might be a minor rather then a patch since it introduces support for new functionality 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds
highlight_typesupport tofiles.completeUploadExternaland thefilesUploadV2method.The
highlight_typeparameter allows specifying the syntax highlighting type for snippet uploads (e.g.python,javascript), enabling optimistic rendering of syntax highlighting before the async upload processing job completes.Per the webapp implementation,
highlight_typeis a per-file property sent inside thefilesarray offiles.completeUploadExternal, not a top-level parameter.Changes
highlight_typeto theFileUploadCompleteinterface (per-file in thefilesarray)highlight_typetoFileUploadV2so it can be specified when usingfilesUploadV2getAllFileUploadsToCompleteto passhighlight_typethrough to each file objectUsage
Requirements