Set a default filename so that Slack displays the preview correctly#375
Open
ts-3156 wants to merge 1 commit intoslack-ruby:masterfrom
Open
Set a default filename so that Slack displays the preview correctly#375ts-3156 wants to merge 1 commit intoslack-ruby:masterfrom
ts-3156 wants to merge 1 commit intoslack-ruby:masterfrom
Conversation
Here's an example of a CHANGELOG.md entry: * [#375](https://github.com/slack-ruby/slack-ruby-client/pull/375): Set a default filename so that slack displays the preview correctly - [@ts-3156](https://github.com/ts-3156).Generated by 🚫 Danger |
Collaborator
|
This file is generated, so you'll need to introduce this as a patch, or we'll lose the change next update of the web API, see https://github.com/slack-ruby/slack-ruby-client/blob/master/CONTRIBUTING.md#patching-slack-web-api. It will also need tests and a README change. Thanks! |
1963b52 to
097b3ca
Compare
Collaborator
|
I still think this is a good idea, any interest in finishing this @ts-3156? We also introduced |
Author
|
@dblock Thank you for your comment. I apologize for neglecting it for so long. I am not currently using Slack so I cannot verify that it works. It is ok to close this issue. I'm sorry for your inconvenience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting at 2021/05/05 05:30 UTC, Slack client no longer correctly displays previews of images when filename is not specified via slack-ruby-client gem.
The reason of this behavior is that when a filename is not set to both
Faraday::UploadIO.newandSlack::Web::Client.new.files_upload, multipart-post gem setslocal.pathas a filename. Iflocal.pathis specified as the filename, Slack will recognize the file as binary and will not show the image preview. In this pull request, I specify the default filename to avoid this behavior.The solution of specifying a default filename may be out of scope for slack-ruby-client gem. If you think so, please feel free to close this pull request.