Skip to content

HTML API: Preserve PRE/LISTING newline skipping after seek#58

Open
sirreal wants to merge 2 commits into
trunkfrom
fix-pre-seek
Open

HTML API: Preserve PRE/LISTING newline skipping after seek#58
sirreal wants to merge 2 commits into
trunkfrom
fix-pre-seek

Conversation

@sirreal

@sirreal sirreal commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • Preserve PRE/LISTING skipped-newline state when seeking back to a bookmarked text token.
  • Restore skipped-newline state during seek() and keep it aligned when pending updates shift token offsets.
  • Add bookmark and modifiable-text regressions for affected update and seek paths.

Testing

  • HTML API and html5lib PHPUnit groups pass.
  • PHPCS, syntax checks, and whitespace checks pass.
  • codex review --base trunk.

Trac ticket: https://core.trac.wordpress.org/ticket/65372

Use of AI Tools

AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5.5
Used for: Diagnosing the seek replay bug, test iteration, PR description cleanup, and code review.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@sirreal sirreal changed the title HTML API: Preserve PRE/LISTING text replay after seek HTML API: Preserve PRE/LISTING newline skipping after seek Jun 12, 2026
@sirreal sirreal marked this pull request as ready for review June 12, 2026 20:45
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell, sergeybiryukov.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant