[Havoc] Preemptive Strike procs on Furious Throws glaive#11114
Merged
ToppleTheNun merged 1 commit intosimulationcraft:midnightfrom Mar 9, 2026
Merged
Conversation
taherbert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preemptive Strike wasn't proccing on the Furious Throws extra glaive from Screaming Brutality auto glaives. The main throw glaive correctly triggered Preemptive Strike (immediate), but the Furious Throws glaive (delayed 400ms) did not.
Fixed by scheduling a delayed Preemptive Strike event alongside the Furious Throws delayed event in
throw_glaive_t::execute().Affects all throw glaive sources (manual cast + all 3 Screaming Brutality paths: blade dance, death sweep, slash proc).
Verified in-game
Every individual glaive (including Furious Throws) triggers Preemptive Strike on first hit (not bounces). For example, Blade Dance with Screaming Brutality + Furious Throws producing 2 secondary glaives yields 6 Preemptive Strike hits: primary glaive, FT from primary, secondary glaive 1, FT from secondary 1, secondary glaive 2, FT from secondary 2.
Sim comparison (4 targets, Havoc Aldrachi Reaver, 5000 iterations)
Exhaustive talent interaction testing
Ran debug sims across 18 talent combinations (PS, FT, SB, SG, SC individually, all pairs, key triples, and all together) to verify no duplicate procs or missing interactions.