chore(triggers): deprecate trigger-save subblock#4107
Conversation
Remove the defunct triggerSave subblock from all 102 trigger definitions, the SubBlockType union, SYSTEM_SUBBLOCK_IDS, tool params, and command templates. Retain the backwards-compat filter in getTrigger() for any legacy stored data.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Keeps backward compatibility by filtering out Reviewed by Cursor Bugbot for commit e26bcfb. Configure here. |
|
@greptile |
|
@cursor review |
Greptile SummaryThis PR removes the defunct Confidence Score: 5/5Safe to merge — pure cleanup with no behavioral changes and a solid backwards-compat filter. All 102 trigger definitions are cleaned up consistently, the SubBlockType union and SYSTEM_SUBBLOCK_IDS are updated, and the backwards-compat filter in getTrigger() handles any residual occurrences. The only finding is a P2 comment clarification with no correctness impact. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[getTrigger called with triggerId] --> B[Look up trigger in TRIGGER_REGISTRY]
B --> C{Trigger found?}
C -- No --> D[throw Error: Trigger not found]
C -- Yes --> E[Filter subBlocks\nremove id === 'triggerSave'\nor type === 'trigger-save']
E --> F[Map subBlocks through\nnamespaceSubBlockId]
F --> G{Is webhook / poller trigger?}
G -- Yes --> H{samplePayload already present?}
H -- No --> I[Inject samplePayload\nsubBlock with outputs mock]
H -- Yes --> J[Return cloned TriggerConfig]
I --> J
G -- No --> J
Reviews (2): Last reviewed commit: "chore(triggers): remove orphaned trigger..." | Re-trigger Greptile |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d0a522c. Configure here.
|
Addressed — removed the orphaned |
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e26bcfb. Configure here.
Summary
triggerSavesubblock from all 102 trigger definitions across every providertrigger-savefromSubBlockTypeunion,SYSTEM_SUBBLOCK_IDS, tool params, and command templatesgetTrigger()to safely handle any legacy stored dataType of Change
Testing
tsc --noEmitpasses with zero errorsChecklist