Skip to content

fix(editor): stop highlighting start.input as blue when block is not connected to starter #4054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Apr 8, 2026
+2 −2
Merged

fix(editor): stop highlighting start.input as blue when block is not connected to starter #4054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...Id]/components/panel/components/editor/components/sub-block/components/formatted-text.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export interface HighlightContext {
highlightAll?: boolean
}

const SYSTEM_PREFIXES = new Set(['start', 'loop', 'parallel', 'variable'])
const SYSTEM_PREFIXES = new Set(['loop', 'parallel', 'variable'])
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Duplicated constant diverges from canonical source

SYSTEM_PREFIXES here is a local copy of SYSTEM_REFERENCE_PREFIXES from references.ts — this PR keeps them in sync, but they can drift again with future changes. Since splitReferenceSegment is already imported from that module, importing SYSTEM_REFERENCE_PREFIXES directly removes the duplication.

Suggested change
const SYSTEM_PREFIXES = new Set(['loop', 'parallel', 'variable'])
import { splitReferenceSegment, SYSTEM_REFERENCE_PREFIXES as SYSTEM_PREFIXES } from '@/lib/workflows/sanitization/references'

Then delete the local const SYSTEM_PREFIXES = new Set(...) declaration entirely.


/**
* Formats text by highlighting block references (<...>) and environment variables ({{...}})
Expand Down
2 changes: 1 addition & 1 deletion apps/sim/lib/workflows/sanitization/references.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { normalizeName, REFERENCE } from '@/executor/constants'

export const SYSTEM_REFERENCE_PREFIXES = new Set(['start', 'loop', 'parallel', 'variable'])
export const SYSTEM_REFERENCE_PREFIXES = new Set(['loop', 'parallel', 'variable'])

const INVALID_REFERENCE_CHARS = /[+*/=<>!]/

Expand Down
Loading