Add ClickHouse 25.8 and 26.3 LTS versions to CI matrix#320
Open
Add ClickHouse 25.8 and 26.3 LTS versions to CI matrix#320
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #320 +/- ##
==========================================
+ Coverage 94.49% 94.60% +0.10%
==========================================
Files 42 42
Lines 709 723 +14
==========================================
+ Hits 670 684 +14
Misses 39 39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
simPod
force-pushed
the
claude/add-clickhouse-lts-versions-Xv70X
branch
from
9e66704 to
69b38a6
Compare
The Time and Time64 types were introduced in ClickHouse 25.6, causing testAllTypesAreCovered to fail on 25.8+ as the registry didn't handle them. https://claude.ai/code/session_01F4RsGjVD4jny3Lder5wqbc
QBit (quantized bit-packed vector storage) was introduced in 25.10 and is GA in 26.2, causing testAllTypesAreCovered to fail on 26.3. https://claude.ai/code/session_01F4RsGjVD4jny3Lder5wqbc
Storage format may differ in newer versions, use assertGreaterThan instead of exact byte size match. https://claude.ai/code/session_01F4RsGjVD4jny3Lder5wqbc
PHPUnit failure: PHP 8.4, ClickHouse 25.8 |
ClickHouse 25.8 changed output_format_json_quote_64bit_integers default to 0, so small UInt64 values (like system.numbers) now come as integers instead of strings in JSON output. Large values (> 2^53) are still quoted. Also removes temporary CI debug steps. https://claude.ai/code/session_01F4RsGjVD4jny3Lder5wqbc
PHPUnit failure: PHP 8.4, ClickHouse 25.8 |
UInt64 values within PHP_INT_MAX range (like 4324182021466249494) now come as integers instead of strings in JSON output since ClickHouse 25.8 changed output_format_json_quote_64bit_integers default to 0. https://claude.ai/code/session_01F4RsGjVD4jny3Lder5wqbc
PHPUnit failure: PHP 8.5, ClickHouse 26.3 |
PHPUnit failure: PHP 8.4, ClickHouse 26.3 |
ClickHouse 26.3 added a Geometry data type to system.data_type_families. Also removes temporary CI debug output. https://claude.ai/code/session_01F4RsGjVD4jny3Lder5wqbc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phpunit-with-clickhouseCI test matrixTest plan
https://claude.ai/code/session_01F4RsGjVD4jny3Lder5wqbc