Fix incorrect PreferenceStorage API usage in HomeViewModel and ConversationActivityV2#1999
Closed
Copilot wants to merge 2 commits intoupdate-pref-usefrom
Closed
Fix incorrect PreferenceStorage API usage in HomeViewModel and ConversationActivityV2#1999Copilot wants to merge 2 commits intoupdate-pref-usefrom
Copilot wants to merge 2 commits intoupdate-pref-usefrom
Conversation
Co-authored-by: SessionHero01 <180888785+SessionHero01@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Refactor preference storage system and tidy up
Fix incorrect PreferenceStorage API usage in HomeViewModel and ConversationActivityV2
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two files were using the old TextSecurePreferences API instead of the new PreferenceStorage system after the preference refactoring.
Changes
HomeViewModel.kt: Fixed
PushPreferences.isPushEnabled(TextSecurePreferences.pushSuffix)→PushPreferences.IS_PUSH_ENABLEDisPushEnabled()function doesn't exist in PushPreferences; the suffix is already embedded in the PreferenceKey constantConversationActivityV2.kt:
TextSecurePreferences.Companion.CALL_NOTIFICATIONS_ENABLEDNotificationPreferences.CALL_NOTIFICATIONS_ENABLED.namefor proper PreferenceKey serialization🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.