Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces reusable Compose components for rendering conversation messages, refactoring the landing screen to use these new components. The changes create a foundation for consistent message display across the app.
Changes:
- Introduced comprehensive message rendering composables supporting text, media, audio, documents, quotes, and links
- Refactored the landing screen to use the new message composables instead of custom implementations
- Updated theme colors and dimensions to support the new message UI components
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| MessageComposables.kt | New file containing all message rendering composables, data models, and preview functions for various message types |
| MessageMedia.kt | New file with media message composables supporting 1-3 images/videos with different layout patterns |
| Landing.kt | Refactored to use new Message composable instead of custom message rendering logic |
| ThemeColors.kt | Updated text bubble colors for all themes to use theme-specific colors instead of hardcoded black/white |
| Dimensions.kt | Added message-specific dimensions including corner radius, min width, icon status size, and quote icon size |
| Colors.kt | Added new black alpha values (blackAlpha12, blackAlpha06) for message backgrounds |
| Themes.kt | Removed unused imports (AppTextSecurePreferences, dp) |
| view_visible_message.xml | Added tools:tint attribute for preview support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/compose/MessageComposables.kt
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/compose/MessageComposables.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/compose/MessageMedia.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/onboarding/landing/Landing.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/compose/MessageComposables.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/compose/MessageComposables.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/compose/MessageComposables.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/compose/MessageComposables.kt
Outdated
Show resolved
Hide resolved
…ompose/MessageComposables.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ompose/MessageMedia.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ompose/MessageComposables.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ompose/MessageComposables.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ompose/MessageComposables.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm bringing the start of the compose content for the conversation screen so we can start using it in other places.