[Fix #1283] Async Java Function Call executor#1285
Merged
fjtirado merged 1 commit intoserverlessworkflow:mainfrom Apr 1, 2026
Merged
[Fix #1283] Async Java Function Call executor#1285fjtirado merged 1 commit intoserverlessworkflow:mainfrom
fjtirado merged 1 commit intoserverlessworkflow:mainfrom
Conversation
69f4f28 to
b073f84
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes issue #1283 by improving the Java function call execution path to correctly support async returns (e.g., CompletableFuture) and explicit output type conversion.
Changes:
- Refactors
CallJavatasks to carry optional input/output class metadata and introduces an abstract base for Java functions. - Updates Java call executors/builders to use typed generics, optional output conversion, and async execution behavior.
- Moves/renames reflection-related functional interfaces/utilities and consolidates/adjusts tests (adds async call test, moves Jackson event filtering test).
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| impl/core/src/main/java/io/serverlessworkflow/impl/events/DefaultCloudEventPredicate.java | Adjusts envelope predicate extraction/removal from additional properties. |
| experimental/types/src/main/java/io/serverlessworkflow/api/types/func/CallJava.java | Adds generics + input/output class metadata and refactors function task hierarchy. |
| experimental/test/src/test/java/io/serverlessworkflow/fluent/test/Review.java | Replaced a test record with a new abstract function base class (currently in test sources). |
| experimental/test/src/test/java/io/serverlessworkflow/fluent/test/JacksonEventFilteringTest.java | Removes standalone Jackson event filtering test (moved/merged elsewhere). |
| experimental/test/src/test/java/io/serverlessworkflow/fluent/test/FuncEventFilterTest.java | Expands event filter tests and inlines Jackson conversion test + domain records. |
| experimental/test/src/test/java/io/serverlessworkflow/fluent/test/FuncCallAsyncTest.java | Adds coverage for async/sync/lambda Java function calls. |
| experimental/lambda/src/test/java/io/serverless/workflow/impl/executors/func/StringBuilder2String.java | Adds converter targetType() to support target-driven conversion. |
| experimental/lambda/src/main/java/io/serverlessworkflow/impl/executors/func/JavaLoopFunctionIndexCallExecutor.java | Fixes executor generics to return typed result. |
| experimental/lambda/src/main/java/io/serverlessworkflow/impl/executors/func/JavaLoopFunctionCallExecutor.java | Fixes executor generics to return typed result. |
| experimental/lambda/src/main/java/io/serverlessworkflow/impl/executors/func/JavaFunctionCallExecutorBuilder.java | Plumbs output class into executor construction. |
| experimental/lambda/src/main/java/io/serverlessworkflow/impl/executors/func/JavaFunctionCallExecutor.java | Updates executor to support typed return + output class conversion. |
| experimental/lambda/src/main/java/io/serverlessworkflow/impl/executors/func/JavaFilterFunctionCallExecutorBuilder.java | Plumbs output class into executor construction. |
| experimental/lambda/src/main/java/io/serverlessworkflow/impl/executors/func/JavaFilterFunctionCallExecutor.java | Updates executor to support typed return + output class conversion. |
| experimental/lambda/src/main/java/io/serverlessworkflow/impl/executors/func/JavaContextFunctionCallExecutorBuilder.java | Plumbs output class into executor construction. |
| experimental/lambda/src/main/java/io/serverlessworkflow/impl/executors/func/JavaContextFunctionCallExecutor.java | Updates executor to support typed return + output class conversion. |
| experimental/lambda/src/main/java/io/serverlessworkflow/impl/executors/func/DataTypeConverterRegistry.java | Tightens registry API to Class<?>. |
| experimental/lambda/src/main/java/io/serverlessworkflow/impl/executors/func/DataTypeConverter.java | Adds targetType() to support target-directed conversions. |
| experimental/lambda/src/main/java/io/serverlessworkflow/impl/executors/func/AbstractJavaCallExecutor.java | Adds output type conversion + async execution handling logic. |
| experimental/fluent/func/src/test/java/io/serverlessworkflow/fluent/func/FuncDSLUniqueIdTest.java | Updates imports after moving UniqueIdBiFunction. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/UniqueIdBiFunction.java | Changes package to io.serverlessworkflow.api.reflection.func. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/Step.java | Updates imports to new reflection function packages. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/SerializablePredicate.java | Changes package to io.serverlessworkflow.api.reflection.func. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/SerializableFunction.java | Changes package to io.serverlessworkflow.api.reflection.func. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/SerializableConsumer.java | Changes package to io.serverlessworkflow.api.reflection.func. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/ReflectionUtils.java | Makes reflection utilities public and adds result type inference. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/InstanceIdFunction.java | Changes package to io.serverlessworkflow.api.reflection.func. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncEventFilterSpec.java | Updates imports to new SerializablePredicate location. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncEmitSpec.java | Updates imports to new reflection utilities and serializable function. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java | Adds output type inference and overloads that accept explicit output classes. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncCallStep.java | Stores return class and forwards it into call task builder configuration. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/CommonFuncOps.java | Updates imports to new reflection utilities/functions. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/FuncForkTaskBuilder.java | Adds branch overload supporting explicit output class. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/FuncEmitEventPropertiesBuilder.java | Updates import to new SerializableFunction package. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/FuncCallTaskBuilder.java | Adds overloads to pass optional output class into CallJava. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/serverlessworkflow/impl/executors/func/JavaContextFunctionCallExecutor.java
Outdated
Show resolved
Hide resolved
experimental/test/src/test/java/io/serverlessworkflow/fluent/test/FuncCallAsyncTest.java
Show resolved
Hide resolved
...lambda/src/main/java/io/serverlessworkflow/impl/executors/func/AbstractJavaCallExecutor.java
Show resolved
Hide resolved
experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java
Outdated
Show resolved
Hide resolved
Signed-off-by: fjtirado <ftirados@redhat.com> [Fix serverlessworkflow#1283] Async Java Function Call executor Signed-off-by: fjtirado <ftirados@redhat.com> Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...lambda/src/main/java/io/serverlessworkflow/impl/executors/func/AbstractJavaCallExecutor.java
Show resolved
Hide resolved
...lambda/src/main/java/io/serverlessworkflow/impl/executors/func/AbstractJavaCallExecutor.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1283