feat: Add custom catch container node#145
Open
lornakelly wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a ReactFlow-specific “catch container” node type so that Catch nodes with nested content can render differently from leaf Catch nodes, and refactors test helpers to reuse a shared createFlatGraph utility.
Changes:
- Added detection of
Catchnodes that have child nodes and map them to a custom ReactFlow node type (catch-container). - Registered a new ReactFlow node type/component for catch containers.
- Extracted a shared
createFlatGraphhelper intotests/test-utilsand reused it across tests.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/serverless-workflow-diagram-editor/src/react-flow/diagram/diagramBuilder.ts | Detect catch container nodes and resolve their ReactFlow node type during diagram build. |
| packages/serverless-workflow-diagram-editor/src/react-flow/nodes/Nodes.tsx | Register catch-container ReactFlow node type and add a placeholder component for it. |
| packages/serverless-workflow-diagram-editor/tests/react-flow/diagram/diagramBuilder.test.ts | Add unit tests for getCatchContainerNodeIds (with some test-name typos to fix). |
| packages/serverless-workflow-diagram-editor/tests/test-utils/graph-helpers.ts | Introduce shared createFlatGraph test helper. |
| packages/serverless-workflow-diagram-editor/tests/test-utils/index.ts | Re-export createFlatGraph from the test-utils barrel. |
Comments suppressed due to low confidence (1)
packages/serverless-workflow-diagram-editor/tests/react-flow/diagram/diagramBuilder.test.ts:465
- There are spelling mistakes in this test name (e.g., "inclyde", "insode"). Please correct them to keep test output readable and searchable.
it("should inclyde nested catch containers insode a parent container", () => {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: lornakelly <lornakelly88@gmail.com>
lornakelly
force-pushed
the
141/catch-container
branch
from
ad0d9d6 to
7105f1e
Compare
fantonangeli
approved these changes
May 14, 2026
Member
fantonangeli
left a comment
fantonangeli
left a comment
There was a problem hiding this comment.
LGTM, I tried to improve getCatchContainerNodeIds() but please check if it does what expected as I only tried with pnpm test
lornakelly
force-pushed
the
141/catch-container
branch
from
b400ae8 to
9d50bcd
Compare
Contributor
Author
|
@ricardozanini if you can merge when you get a chance please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #141
Summary
Resolve catch leaf vs catch container nodes at ReactFlow boundary as this is a rendering concern
Changes