Cloudfront Alternate Domain Names#93
Open
roodrallec wants to merge 6 commits intoserverless-components:masterfrom
Open
Cloudfront Alternate Domain Names#93roodrallec wants to merge 6 commits intoserverless-components:masterfrom
roodrallec wants to merge 6 commits intoserverless-components:masterfrom
Conversation
Alternate cloudfront domains
roodrallec
force-pushed
the
serverless-fork-pr
branch
from
db5fe1c to
f37b009
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a suggestion for allowing alternate cloudfront domain names on component deploy. Previously, manually set alternate domain names are wiped from the cloudfront distribution on deploy.
Use Case
If you would like to add alternate domain names to the cloudfront distribution:
https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/CNAMEs.html#CreatingCNAME
Instructions
To use this configuration, add an
alternateDomainNamesproperty to the serverless.yml file, with a comma separated list of alternate domain names. This component will then ensure that they are added to the cloudfront distribution on deploy and update. You will have to configure the alternate domain names on AWS Route 53 to point to the cloudfront distribution manually.