🔨 Comprehensive benchmarking#64
Draft
serkor1 wants to merge 2 commits into
Draft
Conversation
* The benchmarks have been completely work and now does
one more thing than originally intended: compares with {TTR}
* There are internal benchmarks which compares .Call() to the
different methods which was the original intention of measuring
the overhead of everything that happened around the .Call()
* The benchmarks in general tests a pool a indicators that are
available in both packages to do a more thorough benchmark as opposed
to the original bollinger_bands()-only test.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #64 +/- ##
==========================================
+ Coverage 96.58% 96.67% +0.09%
==========================================
Files 280 280
Lines 21012 21012
==========================================
+ Hits 20294 20314 +20
+ Misses 718 698 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* The original implementation did not account for
output shape. A simple example is bollinger bands where TTR produces
a pctB column, which {talib} omits.
With this commit the output shape is equal on each side to the lowest
commond denominator; ie. if {talib} produces +1 column, then {TTR} is forced
to produce +1 column, and the other way around.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 What?
This PR is focused on the benchmark side of the package. The benchmark serves two purposes:
series()--- this is used for optimizations across commits.