Handle non-standard register sizes; and added pre and post TX delay options for serial.#3
Open
bapowell wants to merge 3 commits into
Open
Handle non-standard register sizes; and added pre and post TX delay options for serial.#3bapowell wants to merge 3 commits into
bapowell wants to merge 3 commits into
Conversation
bapowell
commented
May 27, 2026
- Miscellaneous small fixes/tweaks.
- For ReadHoldingRegs and ReadInputRegs, device (ModbusInterface) can return a (registerSize, valueBuff) tuple to indicate a non-standard register size (i.e. not 2 bytes).
- In ModbusClientPort, for some of the F (fmt) methods, call the extended method in the same class directly. Otherwise the inherited subclass method is called, which isn't the desired behavior in those cases.
- Added preTxDelay and postTxDelay options to ModbusSerialPort.
added 3 commits
May 11, 2026 17:09
…eturn a tuple, (registerSize, valueBuff), to indicate a non-standard register size (i.e. not 2 bytes); various small fixes/tweaks.
…ed method in the same class directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.