feat: enable endpoint version selection#160
Open
trane77 wants to merge 3 commits intosendgrid:mainfrom
Open
Conversation
- add utility method to set a version in the URL - unit test the new functionality - improve readability with null coalescing operator
Author
|
@twilio-dx any news about this PR? Thanks |
Contributor
|
Hi @funder7! We have added this to our list and we'll be prioritising it soon. Thanks! |
Author
|
Hi, do you think that this and the other PR #159 will be merged at some point? :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
This update allows the selection of and endpoint version, needed in cases like Segmenting contacts V2 -> Update segment
As you can see, the example code snippet in the doc, uses a syntax that is not compatible with php (calling the endpoint is in fact not possible):
Contents
Checklist
If you have questions, please file a support ticket.