evmrpc: derive block trace, sei_getCosmosTx, header gasLimit from populated data sources (CON-256)#3452
evmrpc: derive block trace, sei_getCosmosTx, header gasLimit from populated data sources (CON-256)#3452wen-coding wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
PR SummaryMedium Risk Overview
Tests/fixtures are updated to assert non-empty trace output by binding to the seeded deploy tx’s block, and a new positive RPC-IO fixture is added for Reviewed by Cursor Bugbot for commit f33e827. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Summary
Three eth-side block-scoped RPC paths leaned on
/block_resultsdata that isn't populated under Autobahn — they returned empty (or wrong) results regardless of block contents.debug_traceBlockBy*,sei_traceBlockBy*ExcludeTraceFail) now iterates the block's own tx list.sei_getCosmosTxlooks up the cosmos hash directly viareceipt.TransactionIndex, no iteration needed.getHeader(trace path's eth-block construction) sources gasLimit fromsdkCtx.ConsensusParams(), matching the block.go:489-491 pattern already used byeth_getBlockByNumber. Under legacy this also fixes a latent silent fallback toDefaultBlockGasLimit.Existing
.ioxfixtures only asserted response kind, so empty results / early-exit error paths looked indistinguishable from the fix; the trace fixtures now bind to the seeded deploy block and assert non-empty output, and a positive-casegetCosmosTx-deploy.ioxwas added.Supersedes #3449 (closed when the head branch was renamed).
Test plan
go test ./evmrpc/(22.3s)go test ./evmrpc/tests/(27.7s)sei_getCosmosTxfix reverted) on Autobahn: 160/161 — exactly the newgetCosmosTx-deploy.ioxfixture failsgofmt -s -lclean