feat(giga): don't fail if evmone can't load#3443
Conversation
PR SummaryMedium Risk Overview The same best-effort behavior is applied to Reviewed by Cursor Bugbot for commit d863917. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d863917. Configure here.
| panic(fmt.Sprintf("failed to load evmone: %s", err)) | ||
| // evmone is loaded best-effort | ||
| if evmoneVM, err := gigalib.InitEvmoneVM(); err == nil { | ||
| app.GigaEvmKeeper.EvmoneVM = evmoneVM |
There was a problem hiding this comment.
Silently swallowed error hides evmone load failure
Medium Severity
When gigalib.InitEvmoneVM() returns an error, it is silently discarded with no log message. Node operators have no way to know whether evmone loaded successfully or failed — the err from the if init statement is never logged. Given this is explicitly a "best-effort" load for platform compatibility, a logger.Warn on the error path would be important for diagnosability.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit d863917. Configure here.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3443 +/- ##
=======================================
Coverage 59.28% 59.28%
=======================================
Files 2120 2120
Lines 175481 175477 -4
=======================================
- Hits 104029 104027 -2
+ Misses 62384 62383 -1
+ Partials 9068 9067 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| if err != nil { | ||
| panic(fmt.Sprintf("failed to load evmone: %s", err)) | ||
| // evmone is loaded best-effort | ||
| if evmoneVM, err := gigalib.InitEvmoneVM(); err == nil { |
There was a problem hiding this comment.
Is this only invoked once on startup? Can we add a log here showing the error and say we are switching to geth executor?
BTW, is there any chance that we can't load either the evmone or the geth executor?


Describe your changes and provide context
This allows nodes on Ubuntu 22.04 or earlier to use Giga without having to install new deps.
Testing performed to validate your change
Tests pass.