test(evm): wipe stale .openzeppelin manifest before upgradeability test#3431
Open
wen-coding wants to merge 1 commit into
Open
test(evm): wipe stale .openzeppelin manifest before upgradeability test#3431wen-coding wants to merge 1 commit into
wen-coding wants to merge 1 commit into
Conversation
The OZ upgrades plugin caches deployed proxy/impl addresses in contracts/.openzeppelin/unknown-<chainId>.json. After a cluster wipe those addresses no longer exist on-chain and the plugin aborts the Contract Upgradeability test with "No contract at address ... (Removed from manifest)". CI doesn't see this because each job starts from a fresh checkout, but local devs hit it any time they re-run hardhat after a cluster wipe. Drop the manifest in a before() hook scoped to the Upgradeability describe block so each run starts clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contracts/.openzeppelin/unknown-<chainId>.json. After a cluster wipe those addresses no longer exist on-chain and the plugin aborts the Contract Upgradeability test withNo contract at address ... (Removed from manifest).before()hook scoped to theContract Upgradeabilitydescribe block so each run starts clean. Scoped narrowly because only this test uses theupgrades.*namespace; other tests in the suite only use@openzeppelin/test-helpers, which doesn't touch the manifest.Test plan
Local verification on this branch (cluster torn down and re-created with
make docker-cluster-stop && rm -rf build/generated, then restarted, then hardhat re-run — the exact scenario that triggered the failure):Contract Upgradeability → Should allow for contract upgradesfails withNo contract at address 0x... (Removed from manifest).✔ Should allow for contract upgrades (1119ms)); rest of the suite unaffected.Note
Low Risk
Low risk: test-only change that deletes the local OpenZeppelin upgrades manifest to avoid false failures after chain resets; no runtime or contract logic is modified.
Overview
Improves the
Contract Upgradeabilitytest reliability by deleting the cached OpenZeppelin upgrades manifest (contracts/.openzeppelin) in abefore()hook so reruns after a chain/cluster wipe don’t fail due to stale proxy/implementation addresses.Reviewed by Cursor Bugbot for commit ef916a5. Bugbot is set up for automated code reviews on this repo. Configure here.