Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2963 +/- ##
==========================================
- Coverage 58.12% 58.12% -0.01%
==========================================
Files 2111 2111
Lines 173544 173555 +11
==========================================
Hits 100879 100879
- Misses 63706 63717 +11
Partials 8959 8959
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
145d865 to
0a75710
Compare
app/app.go
Outdated
| expectedNonce := app.GigaEvmKeeper.GetNonce(ctx, sender) | ||
| txNonce := ethTx.Nonce() | ||
| if txNonce != expectedNonce { | ||
| // Calculate intrinsic gas for reporting (V2 reports this as gasUsed) |
There was a problem hiding this comment.
can you link where this happens for v2? from what I see the v2 ante handler would just exit with 0 gas used.
not blocking though since gas used no longer affects consensus
There was a problem hiding this comment.
Thanks, you're right. I confused myself with this case below when it does report a value: https://github.com/sei-protocol/sei-chain/pull/2963/changes#diff-0f1d2976054440336a576d47a44a37b80cdf6701dd9113012bce0e3c425819b7R1861
0a75710 to
07d9cce
Compare
07d9cce to
06a7fc6
Compare
Describe your changes and provide context
Reopening #2877 against main
fixes mismatch of this block. there are 2 txs (don't show up on seiscan) that have invalid nonces:
In this case we just bail WITHOUT bumping the nonce.
Testing performed to validate your change
tests pass, get us past the block in question.