Skip to content

Backport release/v6.3: fixed autorestart cooldown#2897

Merged
pompon0 merged 3 commits intorelease/v6.3from
backport-2887-to-release/v6.3
Feb 20, 2026
Merged

Backport release/v6.3: fixed autorestart cooldown#2897
pompon0 merged 3 commits intorelease/v6.3from
backport-2887-to-release/v6.3

Conversation

@seidroid
Copy link

@seidroid seidroid bot commented Feb 17, 2026

Backport of #2887 to release/v6.3.

@seidroid seidroid bot added the backport label Feb 17, 2026
@seidroid
Copy link
Author

seidroid bot commented Feb 17, 2026

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-2887-to-release/v6.3
git worktree add --checkout .worktree/backport-2887-to-release/v6.3 backport-2887-to-release/v6.3
cd .worktree/backport-2887-to-release/v6.3
git reset --hard HEAD^
git cherry-pick -x 8fc1d5b9f36d09cf5e991687f8bd7bda4f04c5bc
git push --force-with-lease

@seidroid seidroid bot mentioned this pull request Feb 17, 2026
@github-actions
Copy link

github-actions bot commented Feb 17, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 20, 2026, 7:30 PM

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 37.25490% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.44%. Comparing base (cf86df0) to head (0e3f943).
⚠️ Report is 1 commits behind head on release/v6.3.

Files with missing lines Patch % Lines
sei-cosmos/server/start.go 0.00% 16 Missing ⚠️
sei-tendermint/cmd/tendermint/commands/run_node.go 0.00% 9 Missing ⚠️
sei-tendermint/node/public.go 0.00% 2 Missing ⚠️
sei-tendermint/test/e2e/node/main.go 0.00% 2 Missing ⚠️
sei-tendermint/cmd/tendermint/main.go 0.00% 1 Missing ⚠️
sei-tendermint/internal/statesync/reactor.go 66.66% 1 Missing ⚠️
sei-tendermint/rpc/test/helpers.go 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (37.25%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (38.45%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           release/v6.3    #2897   +/-   ##
=============================================
  Coverage         43.44%   43.44%           
=============================================
  Files              1866     1866           
  Lines            155401   155361   -40     
=============================================
- Hits              67518    67501   -17     
+ Misses            81843    81817   -26     
- Partials           6040     6043    +3     
Flag Coverage Δ
sei-chain 42.52% <ø> (-0.03%) ⬇️
sei-cosmos 38.21% <38.46%> (-0.01%) ⬇️
sei-db 45.20% <ø> (+0.01%) ⬆️
sei-ibc-go 55.96% <ø> (ø)
sei-tendermint 47.57% <36.00%> (+0.02%) ⬆️
sei-wasmd 41.56% <ø> (+0.01%) ⬆️
sei-wasmvm 39.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-cosmos/server/in_place.go 0.00% <ø> (ø)
sei-cosmos/server/util.go 42.61% <100.00%> (-0.65%) ⬇️
sei-tendermint/config/db.go 0.00% <ø> (ø)
sei-tendermint/internal/blocksync/reactor.go 59.45% <100.00%> (+0.12%) ⬆️
sei-tendermint/node/node.go 57.24% <100.00%> (+0.27%) ⬆️
sei-tendermint/node/seed.go 48.42% <100.00%> (+1.75%) ⬆️
sei-tendermint/cmd/tendermint/main.go 0.00% <0.00%> (ø)
sei-tendermint/internal/statesync/reactor.go 70.82% <66.66%> (ø)
sei-tendermint/rpc/test/helpers.go 0.00% <0.00%> (ø)
sei-tendermint/node/public.go 0.00% <0.00%> (ø)
... and 3 more

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pompon0 pompon0 marked this pull request as ready for review February 20, 2026 16:38
@pompon0 pompon0 requested review from arajasek and masih February 20, 2026 16:38
There was a semantic mismatch between blocksync sending at most 1
message to the restartCh, and WaitForQuitSignals which ignored messages
until cooldown has passed. I think that cooldown in blocksync logic was
exactly trying to avoid sending messages when WaitForQuitSignals could
have ignored them, which is a very fragile way of doing things. This PR
removes cooldown from WaitForQuitSignals, simply delegating the cooldown
logic to blocksync and makes the signal nonblocking and idempotent.

---------

Co-authored-by: Masih H. Derkani <m@derkani.org>
(cherry picked from commit 8fc1d5b)
@pompon0 pompon0 force-pushed the backport-2887-to-release/v6.3 branch from e385726 to 69bf0c1 Compare February 20, 2026 18:33
@pompon0 pompon0 enabled auto-merge (squash) February 20, 2026 18:33
@pompon0 pompon0 merged commit 51bd9a6 into release/v6.3 Feb 20, 2026
47 of 49 checks passed
@pompon0 pompon0 deleted the backport-2887-to-release/v6.3 branch February 20, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants