Backport release/v6.3: fixed autorestart cooldown#2897
Conversation
|
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-2887-to-release/v6.3
git worktree add --checkout .worktree/backport-2887-to-release/v6.3 backport-2887-to-release/v6.3
cd .worktree/backport-2887-to-release/v6.3
git reset --hard HEAD^
git cherry-pick -x 8fc1d5b9f36d09cf5e991687f8bd7bda4f04c5bc
git push --force-with-lease |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (37.25%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release/v6.3 #2897 +/- ##
=============================================
Coverage 43.44% 43.44%
=============================================
Files 1866 1866
Lines 155401 155361 -40
=============================================
- Hits 67518 67501 -17
+ Misses 81843 81817 -26
- Partials 6040 6043 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a semantic mismatch between blocksync sending at most 1 message to the restartCh, and WaitForQuitSignals which ignored messages until cooldown has passed. I think that cooldown in blocksync logic was exactly trying to avoid sending messages when WaitForQuitSignals could have ignored them, which is a very fragile way of doing things. This PR removes cooldown from WaitForQuitSignals, simply delegating the cooldown logic to blocksync and makes the signal nonblocking and idempotent. --------- Co-authored-by: Masih H. Derkani <m@derkani.org> (cherry picked from commit 8fc1d5b)
e385726 to
69bf0c1
Compare
Backport of #2887 to
release/v6.3.