perf: pool VIS, OCC CMS fast path, inline ReadSet, reuse task maps#2844
Draft
pdrobnjak wants to merge 2 commits intoperf/per-index-slots-evm-poolfrom
Draft
perf: pool VIS, OCC CMS fast path, inline ReadSet, reuse task maps#2844pdrobnjak wants to merge 2 commits intoperf/per-index-slots-evm-poolfrom
pdrobnjak wants to merge 2 commits intoperf/per-index-slots-evm-poolfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+409
to
+411
| for k, s := range cms.stores { | ||
| stores[k] = kvHandler(k, s.(types.KVStore)) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+412
to
+416
| for k, parent := range cms.storeParents { | ||
| if _, exists := stores[k]; !exists { | ||
| stores[k] = kvHandler(k, parent.(types.KVStore)) | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
pdrobnjak
force-pushed
the
perf/pool-vis-occ-cms-fastpath
branch
from
d5ca49b to
db03810
Compare
pdrobnjak
force-pushed
the
perf/per-index-slots-evm-pool
branch
from
97596b1 to
58ede27
Compare
1. Remove redundant sort.Strings in SetWriteset/SetEstimatedWriteset
2. Replace 3 global RWMutex+maps with per-tx-index txSlot array
3. Replace select{} workers with for-range + defer close
4. Pool giga EVM executors via sync.Pool within a block
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Pool VersionIndexedStore via sync.Pool to avoid per-tx per-store map allocations (~10 GB reduction) - Add CacheMultiStoreForOCC to build child CMS directly with VIS stores, bypassing intermediate storeParents copy (~16 GB reduction) - Change ReadSet from map[string][][]byte to map[string]ReadSetEntry to eliminate per-key slice allocations (~4.5 GB reduction) - Reuse versionStoresBuf map across task incarnations (~1 GB reduction) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pdrobnjak
force-pushed
the
perf/per-index-slots-evm-pool
branch
from
58ede27 to
8e31c55
Compare
pdrobnjak
force-pushed
the
perf/pool-vis-occ-cms-fastpath
branch
from
db03810 to
5732ec9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
9/13 — depends on perf/per-index-slots-evm-pool
🤖 Generated with Claude Code