Open
Conversation
abueide
requested changes
Jan 7, 2026
Contributor
Implements WaitingPlugin functionality that allows plugins to pause event processing until async operations complete (e.g., permissions, SDK initialization). Key features: - WaitingPlugin base class with pause/resume methods - Automatic event buffering when paused - Support for multiple waiting plugins - 30-second timeout to prevent permanent blocking - Works with both root-level and destination plugins Implementation details: - Add running state to storage (separate from enabled) - Events queued when running=false - Process pending events when all waiting plugins resume - QueueFlushingPlugin respects running state Includes comprehensive tests and documentation with real-world examples (IDFA permissions, native SDK initialization, remote config loading). Co-Authored-By: Claude <noreply@anthropic.com>
abueide
force-pushed
the
waiting-plugin
branch
from
8bb3074 to
82e2dc1
Compare
- Fix strict-boolean-expressions error in QueueFlushingPlugin.ts - Replace 'any' type with proper ClientWithInternals type in tests - All linting errors resolved
MichaelGHSeg
approved these changes
Feb 12, 2026
wenxi-zeng
reviewed
Feb 12, 2026
| } | ||
| if (!this.running.get()) { | ||
| // If not running, queue the event for later processing | ||
| await this.store.pendingEvents.add(event); |
Contributor
There was a problem hiding this comment.
this seems to be redundant with the if block in line 520
wenxi-zeng
reviewed
Feb 12, 2026
| const event = await this.applyContextData(incomingEvent); | ||
| this.flushPolicyExecuter.notify(event); | ||
| return this.timeline.process(event); | ||
| return await this.timeline.process(event); |
Contributor
There was a problem hiding this comment.
await is redundant here
wenxi-zeng
reviewed
Feb 12, 2026
| async flush() { | ||
| // Check if event processing is running | ||
| const running = this.analytics?.running.get(); | ||
| if (running === false) { |
Contributor
There was a problem hiding this comment.
this is a change in behavior. pipeline should still be able to flush. running only disables new event being tracked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add waiting plugin interface.