Skip to content

Add 802.11 HE Operation Info#5029

Open
middleendian wants to merge 3 commits into
secdev:masterfrom
middleendian:dot11_he_operation
Open

Add 802.11 HE Operation Info#5029
middleendian wants to merge 3 commits into
secdev:masterfrom
middleendian:dot11_he_operation

Conversation

@middleendian

Copy link
Copy Markdown
  • 802.11ax-2021 9.4.2.249
  • Add unit test

AI-Assisted: yes (Codex)

PR 0001: Dot11 Element ID Extension and HE Operation

Scope:

  • Adds Dot11EltExtension dispatch for Element ID 255.
  • Adds Dot11EltExtensionGeneric for unknown or unsupported extension IDs.
  • Adds Dot11EltHEOperation for Extended ID 36.
  • Adds Dot11HE6GOperationInfo when the HE Operation element indicates that
    6 GHz operation information is present.
  • Adds focused test/scapy/layers/dot11.uts tests for generic, short, HE, and
    HE 6 GHz extended elements.

Spec references used in code comments:

  • IEEE Std 802.11ax-2021, 9.4.2.1 and Table 9-92: Element ID Extension.
  • IEEE Std 802.11ax-2021, 9.4.2.249: HE Operation element.
  • IEEE Std 802.11ax-2021, Figure 9-788k: 6 GHz Operation Information field.

Intentional partial support:

  • Element ID Extension is a registry for many 802.11 information elements. This
    patch does not try to implement all of them.
  • Unknown and unsupported extension IDs intentionally remain
    Dot11EltExtensionGeneric.
  • EHT Operation and Multi-Link are left for separate follow-up patches so this
    first PR is reviewable on its own.

Focused test command used:

test/run_tests -t test/scapy/layers/dot11.uts -n 57-61 -F

Result:

PASSED=5 FAILED=0

Full dot11 suite note:

  • A full test/scapy/layers/dot11.uts run reached and passed the existing
    tests up through Dot11EltVHTOperation in isolation before I interrupted it
    in this local environment because it was taking longer than expected.
    The focused tests for this patch passed.

- 802.11ax-2021 9.4.2.249
- Add unit test

AI-Assisted: yes (Codex)
Comment thread scapy/layers/dot11.py Outdated
@polybassa

Copy link
Copy Markdown
Contributor

Thanks for the PR. Please fix:

Run bash ./.config/ci/check_commits.sh
ERROR: Commit 401c67cca0091f10734716ea1216dc036ff8a7f6 is missing the 'AI-Assisted: yes|no [tool(s)]' trailer.
ERROR: Commit 1aa5e9bbdc6b7becbf40959b7130d1bf99523a27 is missing the 'AI-Assisted: yes|no [tool(s)]' trailer.
OK: Commit fda60322bd3e6c21e703bc8f65714c213d26f4f9 is properly tagged.

@middleendian

Copy link
Copy Markdown
Author

Thanks for the PR. Please fix:

Run bash ./.config/ci/check_commits.sh
ERROR: Commit 401c67cca0091f10734716ea1216dc036ff8a7f6 is missing the 'AI-Assisted: yes|no [tool(s)]' trailer.
ERROR: Commit 1aa5e9bbdc6b7becbf40959b7130d1bf99523a27 is missing the 'AI-Assisted: yes|no [tool(s)]' trailer.
OK: Commit fda60322bd3e6c21e703bc8f65714c213d26f4f9 is properly tagged.

Fixed commit messages, thanks

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.22%. Comparing base (fbd0956) to head (7461d37).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/dot11.py 97.56% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5029      +/-   ##
==========================================
- Coverage   80.34%   80.22%   -0.13%     
==========================================
  Files         386      387       +1     
  Lines       96034    96446     +412     
==========================================
+ Hits        77154    77369     +215     
- Misses      18880    19077     +197     
Files with missing lines Coverage Δ
scapy/layers/dot11.py 91.84% <97.56%> (+0.38%) ⬆️

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants