-
Notifications
You must be signed in to change notification settings - Fork 633
feat: adjustments for launching Cloak with GalileoV2 #1793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughChanges tighten ValidiumMode validation by restricting fork names to galileov2 and requiring minimum CodecV10 in relayer configuration. A genesis-state-root workaround is removed from batch header encoding. Error messages and comments are updated for consistency. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
rollup/internal/utils/utils.go (1)
129-131:⚠️ Potential issue | 🔴 CriticalNil pointer dereference:
b.Indexaccessed afterb == nilcheck.If
bis nil,fmt.Errorf("batch is nil, version: %v, index: %v", codecVersion, b.Index)will panic.🐛 Proposed fix
if b == nil { - return nil, common.Hash{}, fmt.Errorf("batch is nil, version: %v, index: %v", codecVersion, b.Index) + return nil, common.Hash{}, fmt.Errorf("batch is nil, version: %v", codecVersion) }
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1793 +/- ##
===========================================
+ Coverage 36.39% 36.43% +0.04%
===========================================
Files 248 248
Lines 21329 21321 -8
===========================================
+ Hits 7763 7769 +6
+ Misses 12743 12730 -13
+ Partials 823 822 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Purpose or design rationale of this PR
The codebase already maps CodecV10 (GalileoV2) to Validium V1, which is the intended behavior. Just added a few cleanups and clarifications.
Summary by CodeRabbit