Skip to content

[v1.3] [Editor] TypeScript + (fix) Script State Update + (feat) Edit Conflict Detection (develop/scripteditor-1)#1222

Draft
cyfung1031 wants to merge 4 commits intorelease/v1.3from
develop/scripteditor-1
Draft

[v1.3] [Editor] TypeScript + (fix) Script State Update + (feat) Edit Conflict Detection (develop/scripteditor-1)#1222
cyfung1031 wants to merge 4 commits intorelease/v1.3from
develop/scripteditor-1

Conversation

@cyfung1031
Copy link
Collaborator

  • typeScript: async installScript(param: TScriptInstallParam): Promise<TScriptInstallReturn> { ... }
  • TScriptInstallReturn 加入 updatetime
  • 由 sw 回传的 updatetime 会写入 editors 里的 script 的 updatetime
  • 不传 Script, 改传 getScript, 使 Script state 不用传来传去。 (getScript永远取最新值而非旧State值)
  • Edit Conflict 时 以 modal.confirm 提示
Screenshot 2026-02-07 at 21 24 22

题外话:这个Arco Design 可不可以把确定改左边呀?每次都觉得很奇怪

@cyfung1031 cyfung1031 linked an issue Feb 7, 2026 that may be closed by this pull request
@cyfung1031 cyfung1031 changed the title [v1.3] [Editor] TypeScript + (fix) Script State Update + (feat) Edit Conflict Detection [v1.3] [Editor] TypeScript + (fix) Script State Update + (feat) Edit Conflict Detection (develop/scripteditor-1) Feb 7, 2026
@CodFrm
Copy link
Member

CodFrm commented Feb 8, 2026

正常就是在右边,不做改动(下图为confirm)

image

@cyfung1031
Copy link
Collaborator Author

正常就是在右边,不做改动(下图为confirm)

image


因为 Modal.confirm 置中了,所以才觉得怪
你的图片放右边就正常得多

@cyfung1031
Copy link
Collaborator Author

应该要像 AntDesign 做这种才对

https://nate-luup.github.io/components/modal/

https://codesandbox.io/p/sandbox/4v4d58

Screenshot 2026-02-08 at 12 29 34

@cyfung1031
Copy link
Collaborator Author

cyfung1031 commented Feb 8, 2026

找到了

Screenshot 2026-02-08 at 12 35 01 Screenshot 2026-02-08 at 12 36 18 Screenshot 2026-02-08 at 12 33 53

虽然还是不够 AntDesign 好
(我觉得ArcoDesign的设计者只是把人家的抄过来,但不懂UI/UX设计)
先这样

@CodFrm
Copy link
Member

CodFrm commented Feb 12, 2026

需要先处理 #1223

(也挺奇怪的,两个感觉是独立的功能,应该分开pr)

@CodFrm CodFrm marked this pull request as draft February 12, 2026 10:35
@cyfung1031
Copy link
Collaborator Author

需要先处理 #1223

(也挺奇怪的,两个感觉是独立的功能,应该分开pr)

#1222 是鸡, #1223 是蛋

我没有特殊使用的习惯。都是简简单单一个script 一个名字跟版本
可能这个问题你帮忙改代码吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Editor] 多个分页编辑同一脚本时未检测到版本冲突

2 participants