Skip to content

preliminary cleanup for split_str_once refactor#7258

Draft
Goober5000 wants to merge 1 commit intoscp-fs2open:masterfrom
Goober5000:split_str_once_preliminary_cleanup
Draft

preliminary cleanup for split_str_once refactor#7258
Goober5000 wants to merge 1 commit intoscp-fs2open:masterfrom
Goober5000:split_str_once_preliminary_cleanup

Conversation

@Goober5000
Copy link
Contributor

@Goober5000 Goober5000 commented Mar 1, 2026

String processing enhancement prerequisites for the upcoming split_str_once PR.

  1. Add overloads of some string processing functions with a length parameter, to allow processing of substrings of C-strings
  2. Add overloads of gr_printf that work with string lengths
  3. Add constructors to HUD_message_data and line_node
  4. Rename "size" to "len" in vm_strndup for clarity
  5. Fill in some string attribute annotations
  6. Make the rest of the HUD render functions const
  7. Removed unneeded circular #includes in code/globalincs/memory/

@Goober5000 Goober5000 added the cleanup A modification or rewrite of code to make it more understandable or easier to maintain. label Mar 1, 2026
@Goober5000 Goober5000 marked this pull request as draft March 1, 2026 21:25
@Goober5000 Goober5000 force-pushed the split_str_once_preliminary_cleanup branch 5 times, most recently from ac1be0b to c2d4853 Compare March 2, 2026 01:40
String processing enhancement prerequisites for the upcoming `split_str_once` PR.

1. Add overloads of some string processing functions with a length parameter, to allow processing of substrings of C-strings
2. Add overloads of gr_printf that work with string lengths
3. Add constructors to `HUD_message_data` and `line_node`
4. Rename "size" to "len" in `vm_strndup` for clarity
5. Fill in some string attribute annotations
6. Make the rest of the HUD render functions `const`
7. Removed unneeded circular #includes in code/globalincs/memory/
@Goober5000 Goober5000 force-pushed the split_str_once_preliminary_cleanup branch from c2d4853 to 4855a38 Compare March 2, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup A modification or rewrite of code to make it more understandable or easier to maintain.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant