Skip to content

docs: fix documentation links of checks#819

Closed
denialhaag wants to merge 1 commit into
scientific-python:mainfrom
denialhaag:fix-check-links
Closed

docs: fix documentation links of checks#819
denialhaag wants to merge 1 commit into
scientific-python:mainfrom
denialhaag:fix-check-links

Conversation

@denialhaag

@denialhaag denialhaag commented Jun 24, 2026

Copy link
Copy Markdown

This PR fixes the documentation links of all checks. Currently, the links in the README are missing a pages/.

@drammock

Copy link
Copy Markdown
Member

I think this was fixed by #814 already, and just needs a submodule update in https://github.com/scientific-python/learn.scientific-python.org/

@denialhaag

Copy link
Copy Markdown
Author

The links on https://learn.scientific-python.org/development/pages/guides/repo-review/ are also broken, but I can't find the source code right now. 🤔

@denialhaag

Copy link
Copy Markdown
Author

I think this was fixed by #814 already, and just needs a submodule update in https://github.com/scientific-python/learn.scientific-python.org/

Ahh, I didn't see that! Thanks!

@henryiii

Copy link
Copy Markdown
Collaborator

I can trigger a learn update, sorry about that! MystMD adds the pages due to it being in a pages directory so we had to move the files to get rid of it.

@henryiii

Copy link
Copy Markdown
Collaborator

Thanks for the investigation and the PR though!

@henryiii henryiii closed this Jun 24, 2026
@henryiii

Copy link
Copy Markdown
Collaborator

It was already open, actually, in scientific-python/learn.scientific-python.org#320, just merged it. Should be fixed in a couple of minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants