Adopt the shared Claude review skill (drop vendored copy, add copilot-instructions)#6194
Adopt the shared Claude review skill (drop vendored copy, add copilot-instructions)#6194delthas wants to merge 1 commit into
Conversation
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## development/9.2 #6194 +/- ##
===================================================
- Coverage 84.51% 84.50% -0.02%
===================================================
Files 204 204
Lines 13217 13217
===================================================
- Hits 11171 11169 -2
- Misses 2046 2048 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
Drop the vendored .claude/skills/review-pr/SKILL.md and rely on the shared scality-skills marketplace skill loaded by the reusable review workflow. Move CloudServer's repo-specific review criteria into .github/copilot-instructions.md (read by the marketplace skill), keeping CLAUDE.md as repo context. Matches the vault2 layout. Issue: CLDSRV-930
d8b5e6c to
45108ee
Compare
|
LGTM |
francoisferrand
left a comment
There was a problem hiding this comment.
don't we need to upgrade the GHA workflow file to latest standards as well?
Summary
Migrate CloudServer off the vendored review skill onto the shared marketplace skill, matching vault2 / Zenko / pensieve-api / zenko-operator.
.claude/skills/review-pr/SKILL.mdinto.github/copilot-instructions.md(read by the marketplace skill).claude-code-review.yml@v2workflow already loadsscality-skills@scality-agent-hub, and the vendored copy otherwise shadows it at runtime.CLAUDE.mdstays as repo context.Note: this supersedes the vendored-skill formatting fix in CLDSRV-880 / #6125 — once the skill is deleted, it lives only in agent-hub and fixes propagate automatically.
Issue: CLDSRV-930