Skip to content

Adopt the shared Claude review skill (drop vendored copy, add copilot-instructions)#6194

Open
delthas wants to merge 1 commit into
development/9.2from
improvement/CLDSRV-930/adopt-shared-review-skill
Open

Adopt the shared Claude review skill (drop vendored copy, add copilot-instructions)#6194
delthas wants to merge 1 commit into
development/9.2from
improvement/CLDSRV-930/adopt-shared-review-skill

Conversation

@delthas

@delthas delthas commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Migrate CloudServer off the vendored review skill onto the shared marketplace skill, matching vault2 / Zenko / pensieve-api / zenko-operator.

  • Move CloudServer's repo-specific review criteria from the vendored .claude/skills/review-pr/SKILL.md into .github/copilot-instructions.md (read by the marketplace skill).
  • Delete the vendored skill — the reusable claude-code-review.yml@v2 workflow already loads scality-skills@scality-agent-hub, and the vendored copy otherwise shadows it at runtime.
  • CLAUDE.md stays as repo context.

Note: this supersedes the vendored-skill formatting fix in CLDSRV-880 / #6125 — once the skill is deleted, it lives only in agent-hub and fixes propagate automatically.

Issue: CLDSRV-930

@bert-e

bert-e commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Hello delthas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.50%. Comparing base (a8e3605) to head (45108ee).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph
see 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.2    #6194      +/-   ##
===================================================
- Coverage            84.51%   84.50%   -0.02%     
===================================================
  Files                  204      204              
  Lines                13217    13217              
===================================================
- Hits                 11171    11169       -2     
- Misses                2046     2048       +2     
Flag Coverage Δ
file-ft-tests 68.12% <ø> (-0.06%) ⬇️
kmip-ft-tests 28.41% <ø> (ø)
mongo-v0-ft-tests 69.34% <ø> (-0.04%) ⬇️
mongo-v1-ft-tests 69.40% <ø> (ø)
multiple-backend 35.68% <ø> (ø)
sur-tests 35.96% <ø> (-0.84%) ⬇️
sur-tests-inflights 37.80% <ø> (-0.04%) ⬇️
unit 70.34% <ø> (ø)
utapi-v2-tests 34.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@scality scality deleted a comment from bert-e Jun 18, 2026
@bert-e

bert-e commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

Drop the vendored .claude/skills/review-pr/SKILL.md and rely on the shared
scality-skills marketplace skill loaded by the reusable review workflow.
Move CloudServer's repo-specific review criteria into
.github/copilot-instructions.md (read by the marketplace skill), keeping
CLAUDE.md as repo context. Matches the vault2 layout.

Issue: CLDSRV-930
@delthas delthas force-pushed the improvement/CLDSRV-930/adopt-shared-review-skill branch from d8b5e6c to 45108ee Compare June 19, 2026 07:40
@delthas delthas changed the base branch from development/9.3 to development/9.2 June 19, 2026 07:40
@scality scality deleted a comment from bert-e Jun 19, 2026
@claude

claude Bot commented Jun 19, 2026

Copy link
Copy Markdown

LGTM

Review by Claude Code

@scality scality deleted a comment from claude Bot Jun 19, 2026
@scality scality deleted a comment from claude Bot Jun 19, 2026
@scality scality deleted a comment from bert-e Jun 19, 2026
@delthas delthas requested review from a team, DarkIsDude and SylvainSenechal June 19, 2026 07:46

@francoisferrand francoisferrand left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we need to upgrade the GHA workflow file to latest standards as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants