Skip to content

Improvement/cldsrv 875 integrate shared prettier #6124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benzekrimaha wants to merge 4 commits into
base: development/9.3
Choose a base branch
from
Open

Improvement/cldsrv 875 integrate shared prettier #6124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
57e9e6b
Add shared Prettier tooling
benzekrimaha Apr 29, 2026
d105112
Add Prettier pull request check
benzekrimaha Apr 29, 2026
5d65fec
Format tests workflow with Prettier
benzekrimaha Apr 29, 2026
8cea46e
Document Prettier formatting workflow
benzekrimaha Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/lint.yaml
View file
Open in desktop
Comment thread
benzekrimaha marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
---
name: lint

on:
pull_request:
branches-ignore:
- 'q/*/**'

Copy link
Copy Markdown

@claude claude Bot Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint.yaml uses actions/checkout@v6 and actions/setup-node@v6 while tests.yaml still uses @v4 for both. This inconsistency could cause subtle differences in checkout behavior (e.g. git config, fetch behavior) between the two workflows. Consider aligning both files on the same major version.

— Claude Code

permissions:
contents: read

jobs:
prettier:
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: actions/setup-node@v4
with:
node-version: '22'
cache: yarn
- name: install dependencies
run: yarn install --frozen-lockfile --network-concurrency 1
- name: Prettier (changed files)
shell: bash
env:
BASE_REF: ${{ github.event.pull_request.base.ref }}
run: |
MERGE_BASE=$(git merge-base HEAD "origin/${BASE_REF}")
yarn run --silent prettier:diff --check "${MERGE_BASE}..HEAD"
Loading
Loading