feat: add OCI Helm registry support for agent deployments #255
+246
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for deploying agents using OCI-based Helm registries (e.g., Google Artifact Registry) as an alternative to classic Helm repositories. Changes: - Add `helm_oci_registry` and `helm_chart_version` fields to AgentEnvironmentConfig - Implement auto-login to Google Artifact Registry using gcloud credentials - Add `--use-latest-chart` CLI flag to fetch the latest chart version from OCI registry - Support both classic Helm repo mode and OCI registry mode based on environment config
RoxyFarhad
reviewed
Feb 4, 2026
|
|
||
|
|
||
| def get_chart_reference( | ||
| use_oci: bool, |
Collaborator
There was a problem hiding this comment.
do we need this use_oi ? isn't this implicitly true if oci_registry is not true?
RoxyFarhad
reviewed
Feb 4, 2026
| helm_repository_name = agent_env_config.helm_repository_name | ||
| helm_repository_url = agent_env_config.helm_repository_url | ||
| # Determine if using OCI or classic helm repo mode | ||
| use_oci = agent_env_config.uses_oci_registry() if agent_env_config else False |
Collaborator
There was a problem hiding this comment.
can you make this a helper function that returns chart_reference, chart_version just so its clear that it is always set? Feel like that gets kind of lost here and can cause helm deploy issues
RoxyFarhad
reviewed
Feb 4, 2026
| description="Helm repository url for the environment", | ||
| description="Helm repository url for the environment (classic mode)" | ||
| ) | ||
| helm_oci_registry: str | None = Field( |
Collaborator
There was a problem hiding this comment.
what about making an oci_registry map and then having these as nested values? just so it looks more like an optional config?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for deploying agents using OCI-based Helm registries (such as Google Artifact Registry) as an alternative to classic Helm repositories.
Key Changes
helm_oci_registryandhelm_chart_versiontoAgentEnvironmentConfigfor configuring OCI-based deploymentsgcloud auth print-access-token--use-latest-chartCLI flag that queries GAR for the most recent chart tagUsage
OCI mode (new) - Set
helm_oci_registryin your environment config:Fetch latest chart version:
Classic mode (unchanged) - Continue using
helm_repository_nameandhelm_repository_urlas before.Test plan
--use-latest-chartflag fetches correct version from GAR