Conversation
sampi
force-pushed
the
02-ie11
branch
2 times, most recently
from
e7c9d89 to
16a6b59
Compare
sampi
changed the title
sampi
commented
Apr 22, 2018
| process.env.BABEL_ENV = 'production'; | ||
| process.env.NODE_ENV = 'production'; | ||
|
|
||
| const babelIE11 = require('./patch/babelIE11'); |
Owner
Author
There was a problem hiding this comment.
The babel config needs to be patched before the webpack config, otherwise we're too late and it won't take effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to support IE8 & IE9 anymore…
The same way it was possible to change the
webpackconfig, we're going to do just that tobabel.Files sizes remain the same because there are no 'fancy' methods used in the
preactcode so it compiles just the same on IE9 and IE11.