Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new user setting to toggle progressive blur effects throughout the app, and refactors how blur is applied in the UI to respect this setting. Additionally, it improves permission checks and fallback logic for several Quick Settings tile services, enhancing reliability and compatibility.
Blur Feature Toggle and UI Refactor:
KEY_USE_BLURinSettingsRepository, allowing users to enable or disable progressive blur effects globally. All relevant activities and composables now observeisBlurEnabledand conditionally apply theprogressiveBlurmodifier. [1] [2] [3] [4] [5] [6]progressiveBlurmodifier to be conditional based on the new setting, ensuring a consistent user experience and improved performance when blur is disabled. [1] [2] [3] [4] [5] [6] [7]UI/UX Improvements:
Quick Settings Tile Services – Permission and Fallback Enhancements:
AlwaysOnDisplayTileService,MonoAudioTileService,ChargeQuickTileService, andNfcTileServiceto use a unified logic: first check forWRITE_SECURE_SETTINGSpermission, then fallback to shell-based access if available. This increases compatibility on devices without root or with limited permissions. [1] [2] [3] [4]NfcTileService, added a fallback to shell commands for toggling NFC if the reflection method fails, improving reliability on more devices.Codebase Maintenance:
ShellUtilsandPaddingValuesto support the new logic and UI changes. [1] [2] [3] [4]References:
[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23]