Added support for embedding videos from Gumlet and SproutVideo#258
Open
PrimateCoder wants to merge 2 commits intos9e:masterfrom
Open
Added support for embedding videos from Gumlet and SproutVideo#258PrimateCoder wants to merge 2 commits intos9e:masterfrom
PrimateCoder wants to merge 2 commits intos9e:masterfrom
Conversation
Author
|
Looks I jumped straight to updating the Cache file, but I should have added a site XML file and probably generated the Cache file from there. My bad. I'll look info fixing this by the weekend. |
Add proper XML site definitions for Gumlet and SproutVideo in src/Plugins/MediaEmbed/Configurator/sites/, regenerate the cached definition collection, and add parsing tests following the pattern used by other simple media sites such as medal and streamable. This also fixes the alphabetical ordering of the gumlet entry in the cached collection, which was previously misplaced before googledrive. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PrimateCoder
changed the title
Author
|
I added new definitions for Gumlet and SproutVideo in the correct way. This should be ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It might be optimal not to do any id or token parsing at all, but that wasn't working for me. Either way, this is a more precise URL match.