Skip to content

fix: intro/onboarding screens respect selected theme #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryans-posthog wants to merge 1 commit into from
Closed

fix: intro/onboarding screens respect selected theme #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions apps/code/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,38 @@
<!doctype html>
<html lang="en" class="dark">
<html lang="en">

<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/png" href="/src/renderer/assets/images/bw-logo.png" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>PostHog Code</title>
<script>
// Apply the user's persisted theme before first paint so pre-hydration CSS
// (.dark selectors, --color-background, etc.) matches what React will
// render. Kept in sync post-hydration by syncDarkClass in themeStore.ts.
(function () {
try {
var raw = localStorage.getItem("theme-storage");
var theme = "system";
if (raw) {
var parsed = JSON.parse(raw);
if (parsed && parsed.state && parsed.state.theme) {
theme = parsed.state.theme;
}
}
var isDark =
theme === "dark" ||
(theme === "system" &&
window.matchMedia("(prefers-color-scheme: dark)").matches);
if (isDark) document.documentElement.classList.add("dark");
} catch (e) {
// No persisted preference — let the theme store decide after hydration.
}
})();
</script>
</head>

<body class="bg-dark-bg text-dark-text">
<body>
<div id="root"></div>
<script type="module" src="/src/renderer/main.tsx"></script>
</body>
Expand Down
3 changes: 3 additions & 0 deletions apps/code/src/renderer/components/FullScreenLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@ export function FullScreenLayout({
<Theme
appearance={isDarkMode ? "dark" : "light"}
accentColor={isDarkMode ? "yellow" : "orange"}
grayColor="slate"
panelBackground="solid"
radius="medium"
scaling="105%"
>
<Flex
direction="column"
Expand Down
7 changes: 3 additions & 4 deletions apps/code/src/renderer/styles/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,8 +826,7 @@ body {

:root,
.light,
.light-theme,
.radix-themes {
.light-theme {
--color-background: #f2f3ee;
--terminal-foreground: #0d0d0d;
--terminal-background: transparent;
Expand Down Expand Up @@ -927,8 +926,8 @@ button,
cursor: pointer;
}

/* PostHog Lemon UI button style — applies to solid buttons in explicitly-light Theme wrappers
(auth screen, onboarding flow). Uses the 3D depth shadow and lift-on-hover effect. */
/* PostHog Lemon UI button style — applies to solid buttons in any light-appearance
Theme wrapper. Uses the 3D depth shadow and lift-on-hover effect. */
.radix-themes[data-appearance="light"] .rt-Button[data-variant="solid"] {
box-shadow: 0 3px 0 -1px var(--accent-8);
border-radius: 6px;
Expand Down
Loading