Actually fix "island should be awake" for good, I swear this one works#937
Open
lap2ka wants to merge 1 commit into
Open
Actually fix "island should be awake" for good, I swear this one works#937lap2ka wants to merge 1 commit into
lap2ka wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the wake-up logic for rigid bodies by routing the wake call through the Rapier IslandManager instead of calling wake_up directly on the rigid body. The direct call doesn't notify the island manager, so bodies wouldn't actually resume simulation; using island_manager.wake_up ensures the body is properly re-included in the active island set.
Changes:
- Replace direct
RigidBody::wake_upcall withIslandManager::wake_upin the JNIwakeUpbinding.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
Collaborator
|
PRs should not include the built natives |
Contributor
Author
|
sorry about that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wakey wakey from island manager
