Fix tests to build examples and run on a random port#330
Open
erickt wants to merge 1 commit intorustls:mainfrom
Open
Fix tests to build examples and run on a random port#330erickt wants to merge 1 commit intorustls:mainfrom
erickt wants to merge 1 commit intorustls:mainfrom
Conversation
This makes two changes to the tests to make them a little more reliable: * The tests fail to compile when run with `cargo test --no-default-features`. This changes the tests to shell out to `cargo run ...` to run the examples with the reguired features. * It changes the test to use a random port rather than a fixed one, which might be used by the current system.
erickt
force-pushed
the
fix-tests
branch
2 times, most recently
from
45a0405 to
712d758
Compare
djc
reviewed
Feb 16, 2026
Member
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Thanks for working on this!
This commit has a lot going on, and I'd like it to be split into smaller commits that make one logical change:
- Replace use of existing binaries with using
cargo run - Using a random port
- Potentially other commits with miscellaneous changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes two changes to the tests to make them a little more reliable:
cargo test --no-default-features. This changes the tests to shell out tocargo run ...to run the examples with the reguired features.